29 / 57 · 17 Git & Version Control · Code Review for QA← prev⊞ allnext →☰ Read as one page
4.5Review Workflow Tips
Use Suggested Changes
GitHub's "suggest changes" feature lets you propose specific code edits that the author can accept with one click:
// Instead of fixed wait, use a dynamic condition
await page.waitForSelector('.results', { state: 'visible' });
Batch Your Comments
Read the entire PR before leaving comments. Your comment on line 10 might be answered by code on line 200. Batch all comments and submit them together.
Re-Review Quickly
When the author addresses your feedback, re-review promptly. A review cycle that takes 3 days each round slows everyone down.
Review Your Own PRs First
Before requesting review, read your own diff as if you were the reviewer. You will often catch:
- Debugging code left in (
console.log,test.only) - Missing test cases for edge scenarios
- Unclear variable names
- Accidental file changes (editor config, lockfile churn)