28 / 57 · 17 Git & Version Control · Code Review for QA← prev⊞ allnext →☰ Read as one page
4.4What to Look For in Non-Test PRs (As a QA Engineer)
QA engineers should also review application code PRs through a testability lens:
- Is the change testable? Are there hooks (data-testid attributes, API contracts) that make testing straightforward?
- Are there new error states? New code paths mean new test cases are needed.
- Does it change existing behavior? Existing tests may need updating.
- Are there database migrations? Schema changes can break existing test data.
- Is there adequate error handling? Missing error handling creates untestable failure modes.
// In a review, you might comment:
// "This new endpoint doesn't return a meaningful error for invalid input.
// Could we return a 400 with a JSON body? That would make it much easier
// to write specific assertions in our API tests."